fix(agents-api,typespec): Fix chat/entry typespec models to include tool_calls #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool_calls Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to fa05cd1 in 31 seconds
More details
- Looked at
380lines of code in12files - Skipped
2files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. agents-api/agents_api/autogen/Chat.py:293
- Draft comment:
Ensure thatcreated_atandidfields, which are optional, are properly handled throughout the codebase to avoid potentialNoneTypeerrors. - Reason this comment was not posted:
Confidence changes required:50%
Thecreated_atandidfields inMessageModelare marked asNonein the type hint but are initialized withField(None, ...). This is consistent, but it's important to ensure that these fields are properly handled as optional in the rest of the codebase.
2. scripts/generate_openapi_code.sh:16
- Draft comment:
Thepoetry updatecommands are commented out. Ensure this is intentional and consider uncommenting them if dependency updates are needed. - Reason this comment was not posted:
Confidence changes required:50%
Ingenerate_openapi_code.sh, thepoetry updatecommands are commented out. This might be intentional for testing, but it's important to ensure that dependencies are up-to-date when needed.
3. agents-api/tests/utils.py:7
- Draft comment:
TheChoicesimport was removed. Ensure thatChoicesis not used elsewhere in the code to avoid potential import errors. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is speculative and asks the author to ensure something, which is against the rules. It doesn't point out a definite issue in the code changes made in the diff.
I might be overlooking the possibility that the removal ofChoicescould cause an issue, but the comment doesn't provide a definite issue, just a speculative one.
The rules clearly state not to make speculative comments or ask the author to ensure something. The comment doesn't point out a definite issue.
The comment should be removed because it is speculative and asks the author to ensure something, which is against the rules.
Workflow ID: wflow_UHOw9S5VZwrC6hqU
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Singh Tomer [email protected]
Summary:
This PR updates chat and entry typespec models to include tool calls, modifying both Python and TypeScript files to handle tool call data in chat outputs.
Key points:
MessageModelinagents-api/agents_api/autogen/Chat.pyto includetool_calls.MultipleChatOutputandSingleChatOutputto useMessageModel.tool_callsto TypeScript models insdks/ts/src/api/models/Chat_MultipleChatOutput.tsandChat_SingleChatOutput.ts.sdks/ts/src/api/schemas/$Chat_MultipleChatOutput.tsand$Chat_SingleChatOutput.tsto includetool_calls.typespec/chat/models.tspandtypespec/entries/models.tspto support optionaltool_calls.agents-api/tests/utils.py.Generated with ❤️ by ellipsis.dev