fix(agents-api): Fix prompt step #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 236679b in 12 seconds
More details
- Looked at
223lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_6Zo6ItXPF7D0Nclz
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -15,7 +15,11 @@ | |||
| async def get_execution_details(execution_id: UUID4) -> Execution: | |||
| try: | |||
| return get_execution_query(execution_id=execution_id) | |||
| except AssertionError: | |||
| except AssertionError as e: | |||
| print("-" * 100) | |||
There was a problem hiding this comment.
Replace print statements with a proper logging mechanism for better control over log levels and outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Tomer [email protected]
Summary:
Refactored
prompt_stepandacompletionfunctions for better prompt handling and settings management, improved error handling, and added a new test file.Key points:
prompt_stepinagents-api/agents_api/activities/task_steps/prompt_step.pyto handle prompts and settings more effectively.acompletioninagents-api/agents_api/clients/litellm.pyto manage messages and settings.agents-api/agents_api/routers/tasks/get_execution_details.pyby printing error details.agents-api/agents_api/dependencies/developer_id.pyfor better readability.agents-api/tests/sample_tasks/simple_prompt.yamlfor testing prompt functionality.Generated with ❤️ by ellipsis.dev