feat(agents-api): Add some workflow tests #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3a38e70 in 30 seconds
More details
- Looked at
290lines of code in5files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_yMjqgB0mGFaj7seX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -25,9 +24,6 @@ | |||
| from ...models.execution.create_execution_transition import ( | |||
There was a problem hiding this comment.
The removal of update_execution_query suggests refactoring, but UpdateExecutionRequest is still imported and used only in create_execution_transition. Consider refactoring or clarifying the usage to prevent confusion or dead code.
whiterabbit1983
merged commit 9e4b707
into
dev-tasks-disable-routes
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Tomer [email protected]
Summary:
Added workflow tests and modified transition handling to update execution status in the agents API.
Key points:
UpdateExecutionRequestimport fromagents-api/agents_api/activities/task_steps/__init__.py.printwithactivity.heartbeatintransition_stepfunction inagents-api/agents_api/activities/task_steps/__init__.py.create_execution_transitioninagents-api/agents_api/models/execution/create_execution_transition.pyto update execution status.transition_to_execution_statusmapping inagents-api/agents_api/models/execution/create_execution_transition.py.tasktotask: TaskSpecDefinExecutionInputclass inagents-api/agents_api/common/protocol/tasks.py.agents-api/tests/test_execution_queries.pyandagents-api/tests/test_task_routes.py.Generated with ❤️ by ellipsis.dev