feat(agents-api): Make chat route tests pass #454
Conversation
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5f91ac3 in 1 minute and 45 seconds
More details
- Looked at
1215lines of code in32files - Skipped
2files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. agents-api/agents_api/autogen/Chat.py:90
- Draft comment:
The type ofdeltainChatOutputChunkhas been changed fromChatMLMessagetoInputChatMLMessage. Ensure that this change is intended and thatInputChatMLMessageprovides all necessary fields that were previously used inChatMLMessage. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/autogen/Entries.py:17
- Draft comment:
Therolefield inBaseEntryhas been updated to includeassistantinstead ofagent. Ensure that all references and logic in the codebase that depend on this field are updated accordingly to handle the newassistantrole. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
3. agents-api/agents_api/autogen/Entries.py:122
- Draft comment:
Therolefield inInputChatMLMessagehas been updated to includeassistantinstead ofagent. Ensure that all references and logic in the codebase that depend on this field are updated accordingly to handle the newassistantrole. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_ehe5DBIjxRoRbwCf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on dcc54c4 in 36 seconds
More details
- Looked at
180lines of code in9files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. typespec/chat/models.tsp:191
- Draft comment:
Thelogprobsfield inBaseChatOutput,usagefield inBaseChatResponse, andbytesfield inBaseTokenLogProbshould be updated to be optional to match the changes made in the TypeScript SDK.
logprobs?: LogProbResponse;
usage?: CompetionUsage;
bytes?: uint16[];
- Reason this comment was not posted:
Multiple suggestions found in comment body, which is not allowed by GitHub
Workflow ID: wflow_iGNmsuK0lpv0n58c
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 6279937 in 32 seconds
More details
- Looked at
90lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_JR9jYfqLaqvjSAHE
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ): | ||
| (embed, _) = mocks | ||
|
|
||
| response = make_request( |
There was a problem hiding this comment.
Consider adding an assertion to check the status code of the response to ensure the request was processed successfully. For example:
| response = make_request( | |
| assert response.status_code == 200 |
creatorrr
changed the title
whiterabbit1983
merged commit 67db1fd
into
dev-tasks-disable-routes
Signed-off-by: Diwank Tomer [email protected]
Summary:
This PR adds an
/embedroute for text embedding, refactorsChatMLMessagetoInputChatMLMessage, updates chat logic, and includes tests and SDK updates.Key points:
/embedroute for text embedding inagents-api/routers/docs/embed.py.ChatMLMessagetoInputChatMLMessageacross the codebase.agents-api/sessions.py.render_template_chatml.agents-api/search_docs_hybrid.py.get_messagesandchatfunctions./embedroute inagents-api/tests/test_docs_routes.py.test_chat_routes.py.Generated with ❤️ by ellipsis.dev