feat(agents-api): Preliminary implementation of session.chat #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 10, 2024 19:18
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
…per class inheritance Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 892226d in 4 minutes and 7 seconds
More details
- Looked at
13827lines of code in166files - Skipped
5files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. .env.example:33
- Draft comment:
The removal ofMODEL_API_KEY,MODEL_API_KEY_HEADER_NAME, and related model-serving environment variables needs careful review in the codebase to ensure there are no leftover references that could cause runtime errors. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/autogen/Agents.py:47
- Draft comment:
Thedefault_settingsfield in theAgentmodel should now referenceDefaultChatSettingsinstead of the union type that includedGenerationPresetSettings,OpenAISettings, andVLLMSettings. This change aligns with the removal of theGenerationPresetSettingsmodel and simplifies the settings structure.
default_settings: DefaultChatSettings | None = None
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
3. typespec/agents/models.tsp:50
- Draft comment:
Good use of inheritance inCreateOrUpdateAgentRequestto promote code reuse and maintainability. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a new modelCreateOrUpdateAgentRequestwhich extendsCreateAgentRequest. This model is used to handle both creation and update operations for agents, which simplifies the codebase by reusing the validation and structure ofCreateAgentRequestfor updates as well. This is a good practice as it promotes code reuse and maintainability.
4. agents-api/agents_api/autogen/Chat.py:271
- Draft comment:
TheChatSettingsmodel should extend fromDefaultChatSettingsto utilize proper class inheritance and ensure all settings are consistently applied. This change will help maintain the code's maintainability and ensure consistency across settings.
model ChatSettings extends DefaultChatSettings {
...CommonChatSettings;
}
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_9EdggNYDYrHNrBrB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
merged commit a3377dd
into
dev-tasks-disable-routes
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented preliminary
session.chatinagents-api, reorganized models, addedlitellmclient, and removed deprecated features.Key points:
session.chatinagents-api.prepare_chat_contextinagents-api.session.render_templatesto true by default inagents-api.agents-apiandtypespec.litellmclient inagents-api.model-servingcontainer and support for presets.agents-api..env.examplewith new environment variables.agents-api/agents_api/activities/embed_docs.pyto use new embedding client.agents-api/agents_api/autogenmodels to reflect new chat settings and input data structures.agents-api/agents_api/routers/sessions/chat.pyfor handling chat requests.Generated with ❤️ by ellipsis.dev