fix(openapi): Fix mistakes in openapi.yaml file #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 02dc028 in 52 seconds
More details
- Looked at
469lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Uj1eHemSk8phSWpA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Diwank Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9a5a894 in 1 minute and 26 seconds
More details
- Looked at
73lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. openapi.yaml:1344
- Draft comment:
The schema reference*ref_3was replaced with an explicit schema definition fortask_idandexecution_id. This change is repeated in multiple places. Ensure that this change is intentional and correctly reflects the desired schema structure for these parameters. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. openapi.yaml:1394
- Draft comment:
The security settings for endpoints have been updated to explicitly listapi-key: []instead of using a reference. Confirm that this explicit declaration is intended and correctly implements the required security measures. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_19unmlCwB8vU2hZB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Tomer [email protected]
Summary:
Enhanced
openapi.yamlwith new endpoints, updated existing ones, and refined schemas for better task and execution management.Key points:
openapi.yamlwith new endpoints, updated existing ones, and refined schemas for better task and execution management./agents/{agent_id}/tasks/{task_id}to handleGET,DELETE,PUT, andPATCHoperations./agents/{agent_id}/tasks/{task_id}/executionsto includePOSTandGEToperations with additional query parameters for filtering and sorting./tasks/{task_id}/executions/{execution_id}endpoint to handleGETandPUToperations./executions/{execution_id}/transitionsand/executions/{execution_id}/transitions/{transition_id}endpoints for managing execution transitions.Task,Execution,ExecutionTransition, and added new schemas likeStopExecutionandResumeExecutionTransitionRequest.Generated with ❤️ by ellipsis.dev