fix: Add exception handler for litellm API error #432
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a82b991 in 35 seconds
More details
- Looked at
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_dH0KeLkRm9ELwAUp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -120,6 +121,14 @@ async def prompt_too_big_error(request: Request, exc: PromptTooBigError): | |||
| ) | |||
|
|
|||
|
|
|||
| @app.exception_handler(APIError) | |||
There was a problem hiding this comment.
Consider refining the exception handling for APIError to provide more appropriate HTTP status codes based on the error specifics, rather than defaulting to 500 Internal Server Error. This can help in accurately reflecting the nature of the error to the clients and aid in better error diagnostics.
agents-api/agents_api/web.py
Outdated
| @app.exception_handler(APIError) | ||
| async def litellm_api_error(request: Request, exc: APIError): | ||
| return JSONResponse( | ||
| status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, |
There was a problem hiding this comment.
change this to 502, please
whiterabbit1983
force-pushed
the
x/apierror-exc-handler
branch
from
a82b991
to
cf5ced2
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cf5ced2 in 46 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/web.py:127
- Draft comment:
The PR description states that a 500 Internal Server Error should be returned, but the code returns a 502 Bad Gateway. If the intent is to indicate a server-side error, consider changing the status code to 500.
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_Nya8cwi39nc4aZdX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cf5ced2 in 46 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/web.py:127
- Draft comment:
The PR description states that a 500 Internal Server Error should be returned, but the code returns a 502 Bad Gateway. If the intent is to indicate a server-side error, consider changing the status code to 500.
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_Nya8cwi39nc4aZdX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary:
Added exception handler for
litellm.exceptions.APIErrorinagents-api/agents_api/web.pyto return a 502 Bad Gateway error with the error message.Key points:
litellm.exceptions.APIErrorexception handler inagents-api/agents_api/web.py.APIErroris raised.Generated with ❤️ by ellipsis.dev