fix(sdks/ts): Fix codegen issue #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9b42b6b in 1 minute and 53 seconds
More details
- Looked at
249lines of code in13files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/ts/package.json:78
- Draft comment:
The change in theopenapi-codegenscript to useyq -o=jsonensures compatibility with theopenapitool's input requirements. This is a good fix to ensure the OpenAPI spec is correctly parsed. - Reason this comment was not posted:
Confidence changes required:0%
The PR modifies theopenapi-codegenscript inpackage.jsonto ensure theyqcommand outputs JSON format, which is likely needed for theopenapitool to correctly parse and generate code. This change seems appropriate given the context of generating API client code from an OpenAPI specification.
Workflow ID: wflow_GM2hfVxKO3BsGz4Y
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diwank Tomer [email protected]
Summary:
This PR updates the code generation script for better YAML formatting, adds new UUID models, and simplifies chat message models in the TypeScript SDK.
Key points:
openapi-codegenscript inpackage.jsonto format YAML input correctly.job_id,memory_id, andtool_idwith UUID format.ChatMLMessageandInputChatMLMessagemodels and schemas to have content as a string only.Generated with ❤️ by ellipsis.dev