feat: Add an explicit platform declaration to the services in deploy/docker-compose.yml #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 633d31a in 42 seconds
More details
- Looked at
64lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8hnLVdhV1dELZy9x
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f178178 in 1 minute and 17 seconds
More details
- Looked at
49lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. deploy/docker-compose.yml:49
- Draft comment:
The PR changes the image tags from1.0tocpu-1.0for thetext-embeddings-inferenceservice. This change is not mentioned in the PR description. Please clarify if this change is intentional and update the PR description to reflect this change and its implications. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_0fkjVbKOboQMqVhZ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For supporting macs and other arm based environments
Summary:
This PR adds an explicit
linux/x86_64platform declaration to all services indeploy/docker-compose.yml, updates image tags, and removes GPU-specific configurations to ensure compatibility with Macs and other ARM-based systems.Key points:
platform: linux/x86_64to all services indeploy/docker-compose.yml.1.0tocpu-1.0fortext-embeddings-inferenceservices.text-embeddings-inferenceservices.Generated with ❤️ by ellipsis.dev