-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cache generated responses #336
Conversation
Sweep: PR Reviewagents-api/agents_api/models/session/get_cached_response.pyIntroduced a new function Sweep Found These Issues
julep/agents-api/agents_api/models/session/get_cached_response.py Lines 5 to 11 in 0529b48
View Diff agents-api/agents_api/models/session/set_cached_response.pyIntroduced a new function Sweep Found These Issues
julep/agents-api/agents_api/models/session/set_cached_response.py Lines 5 to 16 in 0529b48
View Diff Potential IssuesSweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.
julep/agents-api/agents_api/models/session/set_cached_response.py Lines 5 to 16 in 0529b48
View Diff julep/agents-api/agents_api/models/session/set_cached_response.py Lines 5 to 16 in 0529b48
View Diff agents-api/agents_api/routers/sessions/session.pyThe changes introduce a caching mechanism using the Potential IssuesSweep isn't 100% sure if the following are issues or not but they may be worth taking a look at.
View Diff agents-api/migrations/migrate_1716013793_session_cache.pyThe changes introduce a new migration script to create and remove a "session_cache" table with key-value pairs. Sweep Found These Issues
julep/agents-api/migrations/migrate_1716013793_session_cache.py Lines 9 to 16 in 0529b48
View Diff The following files were not reviewed because our filter identified them as typically non-human-readable or less important files (e.g., dist files, package.json, images). If this is an error, please let us know.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 0529b48 in 2 minutes and 9 seconds
More details
- Looked at
161
lines of code in5
files - Skipped
1
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_ALt1hiVDIV7A4xm9
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 857d22f in 3 minutes and 34 seconds
More details
- Looked at
68
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_ZLFLTaEafTaSQgCz
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 5e36e05 in 2 minutes and 2 seconds
More details
- Looked at
27
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_gr0rbaliEjp36YPY
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ee589df in 3 minutes and 48 seconds
More details
- Looked at
49
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_h0z5NvAESTETn6uH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Closes #325
Summary:
Introduces caching for generated responses in the agents-api, including new utility functions, a caching decorator, a database migration for cache storage, and a new dependency.
Key points:
get_cached_response
andset_cached_response
functions in/agents-api/agents_api/models/session/
for caching.cache
decorator in/agents-api/agents_api/routers/sessions/session.py
to enable caching for thegenerate
method./agents-api/migrations/migrate_1716013793_session_cache.py
forsession_cache
table.xxhash
dependency inpyproject.toml
for generating cache keys.Generated with ❤️ by ellipsis.dev
Summary:
Enhances the agents-api by introducing caching for generated responses, improving performance and efficiency.
Key points:
get_cached_response
andset_cached_response
in/agents-api/agents_api/models/session/
cache
decorator in/agents-api/agents_api/routers/sessions/session.py
for thegenerate
method/agents-api/migrations/migrate_1716013793_session_cache.py
forsession_cache
tablexxhash
dependency inpyproject.toml
for cache keysGenerated with ❤️ by ellipsis.dev