chore: Update SDKs #333
Merged
chore: Update SDKs #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweep: PR ReviewSweep is currently reviewing your pr... |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 46cce17 in 3 minutes and 26 seconds
More details
- Looked at
1230lines of code in25files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/python/julep/api/types/chat_input_data_tool_choice.py:9
- Draft comment:
The union typeChatInputDataToolChoiceis defined to includeToolChoiceOptionandNamedToolChoice, but it seems like it should also includeNamedToolChoiceFunctionbased on the import statement. This might be an oversight or an incomplete implementation. Please verify ifNamedToolChoiceFunctionshould be part of this union type.
ChatInputDataToolChoice = typing.Union[ToolChoiceOption, NamedToolChoice, NamedToolChoiceFunction]
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_r3A5WKGJVM0bhSNR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/sdk-update
branch
from
46cce17
to
96ae274
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 96ae274 in 2 minutes and 40 seconds
More details
- Looked at
1198lines of code in24files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/python/julep/api/types/doc.py:20
- Draft comment:
The update to allowDoc.contentto be either a string or a list of strings is correctly implemented here and matches the changes in the TypeScript SDK as well. This ensures consistency across different SDKs for handling document content flexibility. - Reason this comment was not posted:
Confidence changes required:0%
The PR updates the SDKs for Python and TypeScript, including changes to the handling of documents. TheDocmodel now supports content being either a string or a list of strings, which is reflected in both Python and TypeScript SDKs. This change is consistent across the codebase, and the PR author has updated the relevant models, types, and schemas to support this new structure.
Workflow ID: wflow_BFd4VyVRF4uUjBeP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/sdk-update
branch
from
96ae274
to
035e7f9
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 035e7f9 in 2 minutes and 25 seconds
More details
- Looked at
3100lines of code in45files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/python/julep/api/types/create_doc.py:20
- Draft comment:
TheCreateDocmodel now correctly usesCreateDocContentfor thecontentfield to support both string and list of strings formats. This change aligns with the updated document handling requirements.
content: CreateDocContent = pydantic.Field(description="Information content")
- Reason this comment was not posted:
Confidence changes required:0%
The Python SDK has been updated to reflect changes in the handling of document content, where the content can now be either a string or a list of strings. This change is reflected in the newCreateDocContentandDocContenttypes, which are used in theCreateDocandDocmodels respectively. This update is consistent across the SDK, ensuring that the document content handling is flexible to accommodate different formats.
Workflow ID: wflow_CgFDGDR5p0cWUlyX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/sdk-update
branch
from
035e7f9
to
fcaf588
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on fcaf588 in 5 minutes and 36 seconds
More details
- Looked at
11146lines of code in187files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/ts/src/api/models/Doc.ts:13
- Draft comment:
Ensure that all parts of the system that interact with thecontentfield ofDocandCreateDocmodels are updated to handle both string and array types. This change might require updates in the handling, validation, and storage of document content. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_afeHiBDAps2uuw9C
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/sdk-update
branch
from
fcaf588
to
3cae337
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 3cae337 in 3 minutes and 54 seconds
More details
- Looked at
11146lines of code in187files - Skipped
3files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. sdks/ts/src/api/models/Doc.ts:13
- Draft comment:
The update to allowcontentto be either a string or an array of strings enhances flexibility and aligns with the PR's goals. Ensure all dependent functionalities are updated to handle both types correctly. - Reason this comment was not posted:
Confidence changes required:33%
The TypeScript SDK has updated the handling of document content to allow it to be either a string or an array of strings. This change is reflected in the models and schemas for bothDocandCreateDoc. This update aligns with the PR description about handling document content as either a string or a list of strings, enhancing flexibility in document content management.
Workflow ID: wflow_8G7UcyifUn61zMrw
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates SDKs across Python and TypeScript, modifying client methods, configurations, and type definitions to align with recent API changes, focusing on enhanced session management and structured document handling, including new handling for document content and IDs.
Key points:
DocIdsfor managing document identifiers.Generated with ❤️ by ellipsis.dev