feat: Improve GitHub action #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to dc6cd1f
- Looked at
13lines of code in1files - Took 1 minute and 26 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. .github/workflows/lint-and-format.yml:20:
- Assessed confidence :
80% - Grade:
0% - Comment:
Consider removing the auto-commit action. It's generally a good practice to let the author review and commit any changes suggested by linters or formatters. - Reasoning:
The PR adds an auto-commit action after the linting and formatting checks. This action will automatically format the code using 'black' and commit the changes. However, this could potentially lead to unexpected changes being committed without the author's knowledge. It's generally a good practice to let the author review and commit any changes suggested by linters or formatters.
Workflow ID: wflow_6QpTf4Z2TUZMD3q5
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested.
- Performed an incremental review on 1fec67b
- Looked at
195lines of code in4files - Took 2 minutes and 2 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_qI09ylyHkM9Uhusn
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested.
- Performed an incremental review on 667c2bb
- Looked at
32lines of code in2files - Took 1 minute and 49 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_swUQasHznN9bZD4c
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested.
- Performed an incremental review on 3bab284
- Looked at
122lines of code in4files - Took 2 minutes and 20 seconds to review
More info
- Skipped
2files when reviewing. - Skipped posting
3additional comments because they didn't meet confidence threshold of50%.
1. agents-api/pyproject.toml:34:
- Assessed confidence :
50% - Comment:
Consider pinning the pytype version to avoid potential issues with future updates. - Reasoning:
The PR author has updated the pyproject.toml files for agents-api, model-serving, and sdks/python. The changes include updating the pytype version and refining the typecheck command. These changes seem to be in line with best practices. However, the pytype version is not pinned and could lead to unexpected behavior if a new version introduces breaking changes.
2. model-serving/pyproject.toml:35:
- Assessed confidence :
50% - Comment:
Consider pinning the pytype version to avoid potential issues with future updates. - Reasoning:
The same issue with the pytype version not being pinned is present in the model-serving/pyproject.toml file. This could lead to unexpected behavior if a new version introduces breaking changes.
3. sdks/python/pyproject.toml:20:
- Assessed confidence :
50% - Comment:
Consider pinning the pytype version to avoid potential issues with future updates. - Reasoning:
The same issue with the pytype version not being pinned is present in the sdks/python/pyproject.toml file. This could lead to unexpected behavior if a new version introduces breaking changes.
Workflow ID: wflow_YUSodilcWUhRixq1
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
alt-glitch
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Update lint-and-format.yml * feat: Update lint-and-format.yml * feat: Parallelize lint-and-format.yml * fix: Update lint-and-format.yml * fix: Disable npm run lint in lint-and-format.yml * fix: Update lint-and-format.yml * fix: Update lint-and-format.yml * fix: Update lint-and-format.yml * fix(.github): Fix github action Signed-off-by: Diwank Singh Tomer <[email protected]> * fix(.github): Fix github action Signed-off-by: Diwank Singh Tomer <[email protected]> * fix(.github): Fix github action Signed-off-by: Diwank Singh Tomer <[email protected]> --------- Signed-off-by: Diwank Singh Tomer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances the GitHub action workflow with automatic code formatting, refines linting commands, updates
pytypeversion inpyproject.tomlfiles, and improves code readability insdks/ts/tests/sessions.test.ts.Key points:
pyproject.tomlfiles ofagents-api,model-serving, andsdks/python.pytypeversion inpyproject.tomlfiles.sdks/ts/tests/sessions.test.ts.Generated with ❤️ by ellipsis.dev