Create an /etc/fstab entry when storage is attached #9599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
approved these changes
Jan 8, 2019
| return errors.Trace(err) | ||
| } | ||
|
|
||
| if _, err = f.WriteString("\n" + entry + "\n"); err != nil { |
There was a problem hiding this comment.
Maybe a comment to indicate that the file will be at the end now?
storage/provider/managedfs_test.go
Outdated
| err := ioutil.WriteFile(filepath.Join(s.fakeEtcDir, "fstab"), []byte(nonRelatedFstabEntry), 0644) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
|
|
||
| mtabEntry := fmt.Sprintf("%s %s other mtab stuff", "/dev/sda1", testMountPoint) |
There was a problem hiding this comment.
Would be a bit clearer with /dev/sda1 in the format string rather than subbed in.
wallyworld
force-pushed
the
storage-attach-fstab
branch
from
37b55e1 to
300d394
Compare
|
|
2 similar comments
|
|
|
|
wallyworld
pushed a commit
to wallyworld/juju
that referenced
this pull request
Jan 11, 2019
juju#9599 ## Description of change When a block device is attached for storage, create an /etc/fstab entry. Delete the /etc/fstab entry when storage is detached. ## QA steps bootstrap aws deploy postgresql with storage ssh into the postgresql machine and check that there's an fstab entry matching the mtab entry detach the storage ensure that the fstab entry is removed ## Bug reference https://bugs.launchpad.net/juju/+bug/1783419
Merged
jujubot
added a commit
that referenced
this pull request
Jan 11, 2019
#9621 ## Description of change Backport some storage fixes from develop: #9599 When a block device is attached for storage, create an /etc/fstab entry. Delete the /etc/fstab entry when storage is detached. #9607 Deploying a charm with storage to maas fails if a placement directive is used, eg --to zone=<blah>. The PR fixes the underlying deployment logic to support that case. Also forward port AWS storage fix from 2.4: #9620 AWS can provision xen pv volumes such that udev info is missing any hardware identifying characteristics. In this case, we need to force a fallback to match on device name, which is not perfect but it's all we can do. ## QA steps bootstrap aws and maas and test postgresql deployments with storage ## Bug reference https://bugs.launchpad.net/juju/+bug/1783419 https://bugs.launchpad.net/juju/+bug/1765959 https://bugs.launchpad.net/juju/+bug/1809478
Merged
jujubot
added a commit
that referenced
this pull request
Jan 16, 2019
#9629 ## Description of change Merge 2.5 into develop picking up these PRs: #9626 fix list offers on k8s models #9625 improved txn pruning #9622 incorrect arch for ec2 a1 instances #9620 handle storage with aws xen pv volumes #9599 write storage mounts to /etc/fstab #9607 maas storage with zone placement #9619 fix raft worker timeouts #9612 Bug 1808947 fix #9585 unplace missing charm profile upgrade data ## QA steps bootstrap smoke test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When a block device is attached for storage, create an /etc/fstab entry.
Delete the /etc/fstab entry when storage is detached.
QA steps
bootstrap aws
deploy postgresql with storage
ssh into the postgresql machine and check that there's an fstab entry matching the mtab entry
detach the storage
ensure that the fstab entry is removed
Bug reference
https://bugs.launchpad.net/juju/+bug/1783419