Register the alternative name for lxd #9468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following registers the alternative name for the localhost lxd provider. This way we can bootstrap juju just using the alternative name "lxd" rather than the perceived more popular one "localhost". The question of if this is correct or not is a bit of a concern. Why we don't reconcile both localhost and lxd names and normalise them to mean the same one when bootstrapping seems a mystery. Anyway, I'll supply a good deal of Cunningham's Law to this and see what the fallout to that is.
jameinel
reviewed
Nov 15, 2018
There was a problem hiding this comment.
Ideally RegisterCredentials would be told information about the cloud that is being used, and it would only register credentials for that cloud. It seems odd that
juju bootstrap lxd-otherhost
would end up trying to connect to my local lxd and generate 'localhost' credentials.
|
Also check if there is no lxd present locally, to allow bootstrapping. |
Disabling lxd (via a snap) and attempting to bootstrap to a local provider works the same as 2.4, which is to say that it outputs the following https://pastebin.canonical.com/p/7WnvnT92v8/ |
SimonRichardson
force-pushed
the
register-lxd
branch
from
2a31d00 to
1c45fe9
Compare
Only register clouds that we're certain we actually need, so in this instance, if you're registering "lxd-test" (a remote server) then the idea is not to register "localhost" or "lxd" credentials.
SimonRichardson
force-pushed
the
register-lxd
branch
from
1c45fe9 to
de3ef0d
Compare
jameinel
reviewed
Nov 16, 2018
The following commit changes the signature of RegisterCredentials. Now the method takes a cloud.Cloud, which should allow other providers to take advantage of possible things like auth types etc. This makes the method a lot more generic and less focused on just the lxd provider.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following registers the alternative name for the localhost
lxd provider. This way we can bootstrap juju just using the
alternative name "lxd" rather than the perceived more popular one
"localhost".
The question of if this is correct or not is a bit of a concern.
Why we don't reconcile both localhost and lxd names and normalise
them to mean the same one when bootstrapping seems a mystery.
Anyway, I'll supply a good deal of Cunningham's Law to this and
see what the fallout to that is.
QA steps
Documentation changes
This is a regression from 2.4, where you could bootstrap using
"lxd" correctly.
Bug reference
N/A