Restoring from file should be repeatable. #8780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExternalReality
force-pushed
the
bug#1771980
branch
from
1358ef8 to
1bee030
Compare
ExternalReality
commented
May 30, 2018
api/backups/restore_test.go
Outdated
| mockBackupFacadeCaller.EXPECT().FacadeCall("List", args, resultBackupList).SetArg(2, testBackupsListResults), | ||
| mockBackupFacadeCaller.EXPECT().FacadeCall("Restore", gomock.Any(), gomock.Any()), | ||
| mockBackupFacadeCaller.EXPECT().FacadeCall("FinishRestore", gomock.Any(), gomock.Any()), | ||
| ) |
There was a problem hiding this comment.
Notice here how we do not make a call to Upload. Any call to upload would break this test. Making an interface for the client and explicitly saying mockBackupClient.EXPECT().Upload(arg).Times(0) would of course be much better.
ExternalReality
force-pushed
the
bug#1771980
branch
3 times, most recently
from
d87c8e4 to
06018f8
Compare
ExternalReality
force-pushed
the
bug#1771980
branch
from
06018f8 to
cc07d2d
Compare
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Restoring a backup from file twice in success fails. Juju should be able to restore a given backup from file more than once.
Why is this change needed?
This change fixes the referenced bug.
How do we verify that the change works?
Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1771980