Add support for charms to inject files into the pod #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmlanigan
reviewed
Feb 15, 2018
caas/containers_test.go
Outdated
| `[1:] | ||
|
|
||
| expectedFileContent := ` | ||
| [config] | ||
| foo: bar`[1:] |
There was a problem hiding this comment.
yaml specifies "|-" hence last \n stripped
i changed to yaml to avoid confusion
| @@ -66,3 +86,20 @@ name: gitlab | |||
| _, err := caas.ParseContainerSpec(specStr) | |||
| c.Assert(err, gc.ErrorMatches, "spec image name is missing") | |||
| } | |||
|
|
|||
caas/containers.go
Outdated
| if fs.MountPath == "" { | ||
| return nil, errors.Errorf("mount path is missing for file spec %q", fs.Name) | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not check to see if files are provided here?
There was a problem hiding this comment.
files might be added later; as a minimum we just set up the mount
wallyworld
force-pushed
the
caas-charm-files
branch
from
4ea359a to
26f9ae1
Compare
|
We don't have tests for k8s.go yet. They will come soon. |
wallyworld
force-pushed
the
caas-charm-files
branch
from
26f9ae1 to
cfe3f49
Compare
babbageclunk
approved these changes
Feb 15, 2018
wallyworld
force-pushed
the
caas-charm-files
branch
from
cfe3f49 to
99aa128
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Charms may specify that they want files at a given mount point to be injected into the unit pods.
QA steps
Run up a caas deployment with my mysql test charm.