-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go-1.9 is now default for juju 2.3 #7903
Conversation
- fan-config model option - fanconfigurer worker setting up fan on machines - fan networking is currently enabled by default for all containers if fan-config is set for the model
- fan-config model option - fanconfigurer worker setting up fan on machines - fan networking is currently enabled by default for all containers if fan-config is set for the model
…fig, autoconfiguration of FAN for ec2, cleanups
When doing Upsert, it doesn't return an error, but it does say that no documents were modified.
If no external-network specified, pick one from same AZ as the instance network. If external-network specified, use that.
Mongo 2.4 appears to have a bug wrt Upsert and $bit operations. See bug #1720155 and #1699678 for more details. This does a Database version check and uses appropriate operations.
|
||
Installing Go | ||
-------------- | ||
|
||
`Juju's` source code currently depends on Go 1.8. One of the easiest ways | ||
`Juju's` source code currently depends on Go 1.9. One of the easiest ways |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This technically isn't true as go-1.8 will still build juju. However, we now feel free to utilize go 1.9+ features, so this feels like a proper recommendation to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Veebers thoughts? |
Added note about standard ssh options. ## Description of change Users were not aware that standard 'ssh' options could also be provided to 'juju ssh' command. Added a paragraph to a command help, similar in wording to 'juju scp'. ## QA steps 'juju help ssh' mentions standard ssh options and man. ## Documentation changes n/a ## Bug reference https://bugs.launchpad.net/juju/+bug/1718775
Add a few extra lines of logging at bootstrap time ## Description of change Add a few extra lines of logging when bootstrapping. Also make the lines consistent with respect to printing "." at the end. ## QA steps $ juju bootstrap Creating Juju controller "foo" on lxd Looking for packaged Juju agent version 2.3-alpha1 for amd64 No packaged binary found, preparing local Juju agent binary Launching controller instance(s) on lxd... - juju-e5e34f-0 (arch=amd64) Installing Juju agent on bootstrap instance Fetching Juju GUI 2.9.2 Waiting for address Attempting to connect to 10.200.103.72:22 Connected to 10.200.103.72 Running machine configuration script... Bootstrap agent now started Contacting Juju controller at 10.200.103.72 to verify accessibility... Bootstrap complete, "foo" controller now available Controller machines are in the "controller" model Initial model "default" added ## Bug reference https://bugs.launchpad.net/juju/+bug/1716730
2.2 pingbatcher 1720155 ## Description of change It turns out that $bit operations do not work well with Upsert and Mongo 2.4. I had written the original patch against Mongo 2.6 which is why I thought everything worked, but it seems that things break if you use the 2.4 that we have on Trusty. ## QA steps The existing test suite would fail if run against Mongo 2.4 which should have caught this, but apparently were weren't actually running there? An easy way to test this is to grab a trusty VM/LXD container, and then 'apt install juju-mongodb' and run the test suite in state/presence. ## Documentation changes None ## Bug reference [lp:1720155](https://bugs.launchpad.net/juju/+bug/1720155)
Netplan containerizer ## Description of change This PR adds support for netplan-configured LXD containers in Juju. ## QA steps juju add-machine --series artful lxd, verify that network inside container is configured properly.
Fix the API break with application config The Application.Get method was updated to change the "default" boolean returned value to "is_default". However this was done on the main facade without adding a method to the v4 backwards compatible shim to keep the old behaviour for old callers. While making this change, it became apparent that there was no way for the user to know whether or not a value was set if it matched the default. This new code removes "is_default", and adds "source", which is one of "unset", "default", "user", and the new key "default" which is the charm default value. ## QA steps deploy something then "juju config <appname>"
Might want to mark https://bugs.launchpad.net/juju/+bug/1516676 as "fix committed" after this is done. |
@dshcherb, |
@axw The cert unit test is causing an error. Can you have a look and correct? |
!!bang!! |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Build failed: Tests failed |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Build failed: Tests failed |
Description of change\
Why is this change needed? This change allows us to build with go-1.9, which will be required for new changes going forward.
QA steps
The merge jobs have been updated as part of the PR to build with go-1.9. The readme and other docs also now mention go-1.9. Once this PR passes, builds should be good to go.