provider/local: don't put tools in cloud-config #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the user-data is not bounded like in ec2 etc., doing this does seem to cause additional load on cloud-init. Fixes https://bugs.launchpad.net/juju-core/+bug/1363143
|
I agree with the other conversations that cloudinit/config.AddBinaryFile with 8MB files should go away and we should be doing this a different way. |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Does not match ['fixes-1363143'] |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 1, 2014
provider/local: don't put tools in cloud-config While the user-data is not bounded like in ec2 etc., doing this does seem to cause additional load on cloud-init. Fixes https://bugs.launchpad.net/juju-core/+bug/1363143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the user-data is not bounded like in ec2
etc., doing this does seem to cause additional
load on cloud-init.
Fixes https://bugs.launchpad.net/juju-core/+bug/1363143