api: fix intermittent test failures #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frobware
approved these changes
Oct 17, 2016
| for i, test := range openWithSNIHostnameTests { | ||
| c.Logf("test %d: %v", i, test.about) | ||
| s.testSNIHostName(c, test.info, test.expectDial) | ||
| } | ||
| } | ||
|
|
||
| // testSNIHostName tests that when the API is dialed with the given info, | ||
| // api.newWebsocketDialer is called with the expected information | ||
| // (one element for each call to newWebsocketDialer) |
There was a problem hiding this comment.
Does the 'one element for each...' still hold true?
There was a problem hiding this comment.
Good catch, thanks. Fixed.
rogpeppe
force-pushed
the
119-fix-snihostname-test-intermittent-failure
branch
from
fc140bd to
ba5e377
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test code assumed that we'd get dial requests in the
order they are specified, but in a heavily loaded test server
this is not necessarily the case, leading to failures like this one:
http://reports.vapour.ws/releases/4490/job/run-unit-tests-xenial-amd64/attempt/1427#highlight
This fixes the test so that we don't rely on the sequential try ordering - the
concurrent retry mechanism isn't something we need to test in this test,
so just connect to a single address in each test.