Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects panics on MacOS Sierra #6455

Merged
merged 1 commit into from
Oct 14, 2016

Conversation

kat-co
Copy link
Contributor

@kat-co kat-co commented Oct 14, 2016

Addresses lp:1633495.

The code was already in place, we just weren't utilizing the correct commits.

Addresses lp:1633495.

The code was already in place, we just weren't utilizing the correct commits.
@kat-co kat-co force-pushed the fixes-1633495-sierra-panic branch from f7b140f to 6a110cf Compare October 14, 2016 17:28
Copy link
Contributor

@reedobrien reedobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinzui
Copy link
Contributor

sinzui commented Oct 14, 2016

LGTM
I built this on sierra and it works :). Thank you very much.

@kat-co
Copy link
Contributor Author

kat-co commented Oct 14, 2016

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Oct 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Oct 14, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9511

@kat-co
Copy link
Contributor Author

kat-co commented Oct 14, 2016

We were running into the cap on simultaneous LXD containers on the testing infrastructure.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Oct 14, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit c2a80a8 into juju:develop Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants