Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge series in metadata #3722

Merged
merged 33 commits into from
Nov 12, 2015
Merged

Conversation

wallyworld
Copy link
Member

This feature branch is bless and can now be merged.

(Review request: http://reviews.vapour.ws/r/3128/)

wallyworld and others added 30 commits September 28, 2015 21:35
Update charmrepo branch dep to charmrepo.v2-unstable, update charm.v6-unstable dep

Update deps to kick off some api changes.

(Review request: http://reviews.vapour.ws/r/2768/)
Add support for deploying and upgrading charms from a specified path

This PR relies on an update to the charmrepo repository that is still under review. That will need to land first before this.

We now support deploying a charm by specifying an arbitrary path - no local repo is needed. Such charms may be multi-series, and a new --series argument is added to allow the user to specify what series to use when deploying. When upgrading, the same series as the originally deployed charm is used.

eg
$ juju deploy /path/to/charm/mycharm --series trusty

$ juju upgrade-charm --path /path/to/charm mycharm

Juju doesn't store the path used to deploy the charm, so it needs to be specified again when upgrading. This might be revisited. A check is done to ensure the same charm directory is used (the name from metadata is being deprecated).


(Review request: http://reviews.vapour.ws/r/2802/)
Local deploys/upgrades must use absolute paths; adjust status output

A few changes here based on feedback from lightning talk at recent sprint.
1. deploy/upgrade from path requires absolute path, otherwise it interprets as cs charm.
2. tabular status output for machine does not show hardware string but rather just az
3. status does not show series in charm urls (series can be seen on machine info)
4. upgrade does not complain if revision file has not been edited

(Review request: http://reviews.vapour.ws/r/2888/)
@wallyworld
Copy link
Member Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 12, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Nov 12, 2015
Merge series in metadata

This feature branch is bless and can now be merged.

(Review request: http://reviews.vapour.ws/r/3128/)
@jujubot jujubot merged commit e16fa23 into juju:master Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants