Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport pull request #17744 from wallyworld/fix-results-check #17748

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

wallyworld
Copy link
Member

@wallyworld wallyworld commented Jul 16, 2024

Backport #17744

The test to check the status of the context dependent tests also needed to check for skipped status. As far as Required is concerned, skipped tests count as success, but the result is 'skipped'.

Links

Jira card: JUJU-6356

juju#17744

The test to check the status of the context dependent tests also needed to check for skipped status.
As far as Required is concerned, skipped tests count as success, but the result is 'skipped'.

## Links

Jira card: [JUJU-6356](https://warthogs.atlassian.net/browse/JUJU-6356)

[JUJU-6356]: https://warthogs.atlassian.net/browse/JUJU-6356?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good old skip check.

@wallyworld
Copy link
Member Author

/merge

@wallyworld
Copy link
Member Author

/merge

1 similar comment
@wallyworld
Copy link
Member Author

/merge

@jujubot jujubot merged commit 0f09c39 into juju:3.6 Jul 17, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants