feat: pebble identities with rootless charms #17578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
added
3.6
dependencies
hpidcock
changed the title
hpidcock
removed
has merge conflicts
do not merge
wallyworld
approved these changes
Jul 19, 2024
|
/merge |
jujubot
added a commit
that referenced
this pull request
Jul 22, 2024
#17783 Merges the following patches: - #17761 - #17768 - #17578 - #17764 - #17763 - #17762 - #17760 - #17745 - #17486 ### Conflicts - apiserver/facades/client/client/client.go - apiserver/facades/client/client/client_test.go - apiserver/facades/client/controller/controller.go - apiserver/facades/client/controller/controller_test.go - apiserver/facades/client/controller/destroy_test.go - apiserver/facades/client/controller/register.go - apiserver/facades/client/modelupgrader/upgrader_test.go - caas/kubernetes/provider/application/application_test.go - cmd/containeragent/initialize/command.go - cmd/containeragent/initialize/package_test.go - cmd/juju/metricsdebug/collectmetrics.go - cmd/juju/metricsdebug/metrics.go - cmd/juju/waitfor/waitfor.go - docker/registry/mocks/registry_mock.go - go.mod - go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses updated pebble version with pebble identities so that the charm container in a k8s deployment can run without root and connect to the pebble instances running in the workload containers (who may be running as a different user).
With this patch the charm can specify in the metadata.yaml a charm-user field with either the values root, non-root or sudoer.
QA steps
./main.sh -p k8s -c minikube sidecar test_rootlessDocumentation changes
Document in metadata.yaml docs the
charm-userfield.Links
Jira card: JUJU-5130