[JUJU-163]create openstack FIPs on networks on AZ to match the server's addresses. #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choose an external network for a FIP based on the AZ of the instance if an external-network has not been configured.
All Networking related interfaces moved and added to a new file. The networkingBase struct because a wrapper for the Environ and implementer of the new NetworkingBase interface.
hmlanigan
added
kind/bug
Compute and Network AZ are created independently in OpenStack. No guarentee they are called the same. Find the server Addresses, then use the AZ of the networks those Addresses are on to find external networks to create FIPs on.
Related updates to unit tests for fix for LP:1928979.
hmlanigan
force-pushed
the
openstack-network-az
branch
from
ca04b61 to
3fad2fd
Compare
hmlanigan
removed
the
do not merge
manadart
approved these changes
Nov 9, 2021
| netIds = append(netIds, network.Id) | ||
| break | ||
| } | ||
| } | ||
| if azName == "" && len(network.AvailabilityZones) == 0 { | ||
| if azNames.IsEmpty() || len(network.AvailabilityZones) == 0 { |
There was a problem hiding this comment.
Let's log out that we including this network because of the absence of AZ specificity. Users wondering at this behaviour will have something to go on.
| "github.com/juju/juju/core/instance" | ||
| ) | ||
|
|
||
| type networkingSuite struct { |
Let users know why an external network was included for potential FIP allocation if AZs are not found.
|
|
hmlanigan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Openstack provider to select networks to create a FIP in based on the AZs of networks the server is attached to.
Refactored some and added interfaces to Openstack networking to mock tests.
Drive by adds ProviderNetworkId to SubnetInfo for Openstack subnets.
QA steps
Bootstrap OpenStack clouds. Finding one with multiple AZ configurations would be interesting.
Bug reference
https://bugs.launchpad.net/juju/+bug/1928979