Worker v3 fixes #13413
Merged
Worker v3 fixes #13413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
worker-v3-fixes
branch
from
a970a5e to
dee0c59
Compare
wallyworld
force-pushed
the
worker-v3-fixes
branch
from
dee0c59 to
10364de
Compare
hpidcock
approved these changes
Oct 13, 2021
wallyworld
force-pushed
the
worker-v3-fixes
branch
5 times, most recently
from
fa68e08 to
7d8fafe
Compare
|
|
…to fully be terminated by the runner
wallyworld
force-pushed
the
worker-v3-fixes
branch
from
7d8fafe to
79a364e
Compare
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Oct 15, 2021
#13421 Merge 2.9 #13406 Take into account manual machine arches when validating constraints #13409 Fix podspec deployment/statefulset/daemonset upgrade. #13410 update-k8s also updates any controller proxy #13411 Acceptance tests - move away from unsupported series #13402 grab bag of metrics updates #13414 Remove ContainerBridgeName bootstrap configuration #13415 Introduce assumes expression sat checker #13420 Sync tools help msg #13413 Worker v3 fixes The restorewatcher files in conflict have been deleted from develop branch. ``` # Conflicts: # apiserver/params/charms.go # caas/kubernetes/provider/bootstrap_test.go # charmhub/refresh.go # go.mod # go.sum # state/open.go # worker/restorewatcher/manifold.go # worker/restorewatcher/manifold_test.go # worker/restorewatcher/worker.go # worker/restorewatcher/worker_test.go ``` ## QA steps See PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
juju/workerdependency tov3so that a new APIWaitWorkercan be used.The first commit is the dependency update. The second commit are the functional changes to Juju.
Basically, when a worker is stopped and the same named worker may need to be started again with a different config, the
WaitWorkerapi needs to be called first to ensure the previously stopped worker is fully terminated in the runner.A new helper function
ReplaceStoppedWorkeris added to wrap the calls to Wait and Run.QA steps
The issue showed up in unit tests - it is very intermittent.
I did a regression test by deploying a cmr relation and adding/removing offers / saas.
I also deployed, removed, and deployed a k8s charm.
Bug reference
https://bugs.launchpad.net/juju/+bug/1945999