-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controller config caas-image-repo supports private or non dockerhub repos #13192
Conversation
…ng updating all operators;
…s provided during bootstraping;
…perator pods to use docker auth details for private repositories;
…uth details here;
…ons from a private registry;
5b3fed1
to
40c1e53
Compare
This is looking promising, let's please make sure a section ends up in the docs for this! :) |
…te OCI registry support;
Yes, That's in the plan. |
…car containers using for private repo;
…use we do not need to watch controller config anymore;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice.
One issue that needs fixing before landing - the apiserver/params should not use structs from other packages. We need to define bespoke structs in params and use helper methods to marshall/unmarshall.
apiserver/facades/controller/caasapplicationprovisioner/provisioner.go
Outdated
Show resolved
Hide resolved
eb362a0
to
bbde416
Compare
!!build!! |
7bd43e7
to
63c9ce8
Compare
…or further work on that;
63c9ce8
to
039f193
Compare
|
#13304 Merge from 2.9 bringing forward: - #13303 from wallyworld/unit-relation-tracing - #13279 from juju/dependabot/github_actions/actions/setup-go-2.1.4 - #13293 from wallyworld/rotate-secret-watcher - #13300 from manadart/2.9-net-info-mod-cfg - #13292 from achilleasa/2.9-use-cidr-in-cidr-fallback-when-matching-machine-addr-cidrs-to-subnets - #12569 from juju/devVersions - #13286 from hpidcock/fix-report-hook-error - #13285 from ycliuhw/fix/registry-basic-auth - #13289 from achilleasa/2.9-ignore-fan-subnets-when-querying-equinix-api - #13290 from wallyworld/remote-application-history - #13281 from ycliuhw/fix/lp-1941055 - #13288 from SimonRichardson/add-logging-for-missing-relation-key - #13287 from SimonRichardson/trap-upgrade-series-interrupt - #13283 from SimonRichardson/remote-connections-not-found - #13284 from wallyworld/remote-relationunit-notfound - #13276 from manadart/2.9-lease-manager-tick-schedule - #13282 from manadart/2.9-net-get-bridge-address - #13280 from SimonRichardson/upstream-raft-part-deux - #13192 from ycliuhw/fix/lp-1935953 - #13251 from jameinel/2.9-proxy-issue-4 - #13275 from jujubot/increment-to-2.9.13 - #13273 from wallyworld/update-secrets - #13270 from manadart/2.9-remote-rels-suite Conflicts: - .github/workflows/build.yml - .github/workflows/client-tests.yml - .github/workflows/static-analysis.yml - CONTRIBUTING.md - caas/broker.go - caas/kubernetes/provider/bootstrap.go - caas/kubernetes/provider/bootstrap_test.go - caas/kubernetes/provider/operator.go - caas/mocks/broker_mock.go - cloudconfig/podcfg/image.go - cloudconfig/podcfg/podcfg_test.go - cmd/juju/commands/upgrademodel.go - cmd/juju/commands/upgrademodel_test.go - controller/config_test.go - feature/flags.go - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go - worker/uniter/relation/statetracker.go - worker/uniter/uniter_test.go
This PR introduces non-dockerhub/private OCI registry support for:
This PR currently enabled
basic
auth andauth token
support.The v2 bear token is still a
TODO
and will be added in the following PRs.Note: this feature is currently hidden under featureflag:
private-registry
, but it's not testable without some hack because this bug(it will be fixed soon).Checklist
Requires a pylibjuju changeAdded integration tests for the PRAdded or updated doc.go related to packages changedQA steps
private repo on non dockerhub
public repo on dockerhub
Documentation changes
Yes
Bug reference
https://bugs.launchpad.net/juju/+bug/1935953
https://bugs.launchpad.net/juju/+bug/1935830