Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Use 'juju exec' instead of 'juju run' for acceptance tests #12483

Merged
merged 2 commits into from
Jan 5, 2021
Merged

[dev] Use 'juju exec' instead of 'juju run' for acceptance tests #12483

merged 2 commits into from
Jan 5, 2021

Conversation

achilleasa
Copy link
Contributor

@achilleasa achilleasa commented Jan 5, 2021 •
edited
Loading

The "juju run" command on the develop branch is now used to execute
actions. The previous functionality is now provided by the "juju exec"
command instead. This commit updates the acceptance tests to use the new
command.

QA steps

You will need a python 2 virtual env for this. The tests have been updated to work with python3

make install
cd acceptancetests
./deploy_job.py lxd `which juju` ./tmp/art nw-deploy-lxd

SimonRichardson
SimonRichardson requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be really bad here and say python 3... python 2 is dead and so should our support for tests that don't support python 3.

Otherwise, the code is fine.

@achilleasa
Copy link
Contributor Author

@SimonRichardson the deploy_stack-based ones should (at least one of them does) run with python3 now.

@achilleasa achilleasa changed the title Use 'juju exec' instead of 'juju_run' for acceptance tests Use 'juju exec' instead of 'juju run' for acceptance tests Jan 5, 2021
@achilleasa achilleasa changed the title Use 'juju exec' instead of 'juju run' for acceptance tests [dev] Use 'juju exec' instead of 'juju run' for acceptance tests Jan 5, 2021
pengale
pengale approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment with a check that looked a bit wordy for my tastes. Changes aren't necessary, though, and this generally LGTM.

acceptancetests/deploy_stack.py Outdated Show resolved Hide resolved
SimonRichardson
SimonRichardson approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than @petevg nit's I think I'm fine with this.

@achilleasa
Use 'juju exec' instead of 'juju_run' for acceptance tests
373d31a 
The "juju run" command on the develop branch is now used to execute
actions. The previous functionality is now provided by the "juju exec"
command instead. This commit updates the acceptance tests to use the new
command.
@achilleasa
Make acceptance tests using deploy_stack.py python3-friendly
f8f004e
@achilleasa achilleasa force-pushed the dev-use-juju-exec-instead-of-juju-run-for-acceptance-tests branch from 111a15a to f8f004e Compare January 5, 2021 17:05
@achilleasa
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit 8db698e into juju:develop Jan 5, 2021
@achilleasa achilleasa deleted the dev-use-juju-exec-instead-of-juju-run-for-acceptance-tests branch January 5, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

@pengale pengale pengale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achilleasa @pengale @SimonRichardson @jujubot