[dev] Use juju ssh to reboot machines in acceptance tests #12477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, some of the acceptance tests would use `juju run` to reboot machines. However, the develop branch has removed support for '--machine' from juju run causing these tests to fail. This commit updates the affected tests to use `juju ssh` instead. In addition, this commit also updates assess_container_networking to work with python 3 by changing x.iteritems() to iter(x.items()).
SimonRichardson
approved these changes
Jan 4, 2021
|
!!build!! (changes only affect the acceptance tests; check-multi-juju should not fail) |
|
|
achilleasa
deleted the
dev-use-juju-ssh-to-reboot-machines-in-acceptance-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, some of the acceptance tests would use
juju runto reboot machines. However, the develop branch has removed support for
'--machine' from juju run causing these tests to fail. This commit
updates the affected tests to use
juju sshinstead.In addition, this commit also updates assess_container_networking to
work with python 3 by changing
x.iteritems()toiter(x.items()).NOTE: after landing these changes we will need to update the CI jobs to use python 3 for any tests that use
assess_container_networking.QA steps
Run the following tests: