Add bootstrap support for setting up storage pools #12109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manadart
reviewed
Oct 9, 2020
|
|
wallyworld
force-pushed
the
bootstrap-storage-pools
branch
from
eba5aa7 to
ec6e7bb
Compare
|
|
wallyworld
force-pushed
the
bootstrap-storage-pools
branch
from
ec6e7bb to
b3df67b
Compare
|
|
wallyworld
force-pushed
the
bootstrap-storage-pools
branch
from
b3df67b to
637fb0a
Compare
|
|
wallyworld
force-pushed
the
bootstrap-storage-pools
branch
from
637fb0a to
e655b23
Compare
|
|
2 similar comments
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR #12096 added support for creating Azure encrypted disks from a storage pool and root-disk-source constraint.
However, there was no way to do this for the controller as the storage pool did not exist yet.
This PR allows the creation of a named storage pool at bootstrap, and wires up the controller instance creation to configure the root disk volume params from that storage pool definition. Allowance is made for multiple storage pools, even though right now the CLI can just support the one.
The same arg handling as is used for
--configis used here. Either a YAML file or multiple cmd args can be used.QA steps
Check that the Azure controller VM uses disk encryption.
Check that the controller model has the storage pool created.
Bug reference
https://bugs.launchpad.net/juju/+bug/1892485