Adds upgrade worker to model agent #11693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
reviewed
Jun 16, 2020
tlm
force-pushed
the
model-admission-upgrade
branch
2 times, most recently
from
ba7ba32 to
b50c1c4
Compare
tlm
force-pushed
the
model-admission-upgrade
branch
from
b50c1c4 to
a6c5b17
Compare
tlm
force-pushed
the
model-admission-upgrade
branch
4 times, most recently
from
7d2e1cf to
8afe00a
Compare
wallyworld
approved these changes
Jul 1, 2020
Comment on lines
+16
to
+18
| JujudOCINamespace = "jujusolutions" | ||
| JujudOCIName = "jujud-operator" | ||
| JujudbOCIName = "juju-db" |
There was a problem hiding this comment.
These shouldn't be exported.
The PR uses them in tests but the tests should use string literals so that if ever we change these consts, the tests will break and we fix the test; it makes us aware of the impact of any change and think about the consequences etc
There was a problem hiding this comment.
The tests wouldn't break if we changed these. I am just trying to keep it consistent. Still want them changed?
tlm
force-pushed
the
model-admission-upgrade
branch
4 times, most recently
from
534e190 to
7031dee
Compare
tlm
force-pushed
the
model-admission-upgrade
branch
from
7031dee to
f187d71
Compare
|
|
jujubot
added a commit
that referenced
this pull request
Jul 2, 2020
#11795 Merge from 2.8 to bring forward: - #11794 from manadart/2.8-address-conversion-rework - #11789 from SimonRichardson/actions-list-output - #11693 from tlm/model-admission-upgrade - #11785 from manadart/2.8-machiner-lld-prep - #11790 from achilleasa/2.8-filter-non-live-relations-from-relation-ids-output - #11792 from wallyworld/add-centos8 - #11791 from howbazaar/2.8-fix-intermittent-status-tests - #11787 from hmlanigan/add-k8s-error-output - #11780 from SimonRichardson/api-schema-admin - #11773 from tlm/json-num - #11783 from wallyworld/merge-2.7-20200701 - #11776 from ycliuhw/lp-1882149 - #11778 from manadart/2.8-instance-poller-dev-provider-id - #11765 from achilleasa/2.8-enable-relation-list-to-show-remote-application - #11768 from ycliuhw/fix/CAAS-CI-LB-GET - #11770 from hmlanigan/unicode-vs-str - #11769 from hmlanigan/unicode-vs-str - #11766 from hmlanigan/autoload-cred-lxd
|
Merged without a description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide the following details to expedite Pull Request review:
Checklist
Description of change
Please replace with a description about why this change is needed, along with a description of what changed?
QA steps
Please replace with how we can verify that the change works?
2nd
Documentation changes
Please replace with any notes about how it affects current user workflow? CLI? API?
Bug reference
https://bugs.launchpad.net/juju/+bug/1883188