vsphere: Enable using datastores in folders #11528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the vsphereclient Datastores method to return datastores under foldes under the Datastores root folder. We don't keep track of the inventory path of the datastore - when the name of the datastore is used for creating a new vm it's looked up on the compute resource, so the inventory path isn't needed.
|
|
4 tasks
jujubot
added a commit
that referenced
this pull request
May 5, 2020
…ders #11532 ### Checklist - [ ] Checked if it requires a [pylibjuju](https://github.com/juju/python-libjuju) change? - [ ] Added [integration tests](https://github.com/juju/juju/tree/develop/tests) for the PR? - [ ] Added or updated [doc.go](https://discourse.jujucharms.com/t/readme-in-packages/451) related to packages changed? - [ ] Do comments answer the question of why design decisions were made? ---- ## Description of change Update the vsphereclient Datastores method to return datastores in folders under the root folder. Without this we will reject the creation saying there's no such datastore. We don't keep track of the inventory path of the datastore - when the name of the datastore is used for creating a new vm it's looked up on the compute resource, so the fully-qualified inventory path isn't needed. This is a backport of #11528 to the 2.7 branch - I'd intended to land it here first and then merge it forward but forgot to update the target branch. ## QA steps * Bootstrap a vsphere controller. * Deploy an application using the name of a datastore that's nested under a folder. ```sh juju deploy ~jameinel/ubuntu-lite --constraints "root-disk-source=datastore-name" ``` The deployment succeeds and the machine is created on the specified datastore. ## Documentation changes None ## Bug reference https://bugs.launchpad.net/juju/+bug/1874031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Update the vsphereclient Datastores method to return datastores in folders under the root folder. Without this we will reject the creation saying there's no such datastore. We don't keep track of the inventory path of the datastore - when the name of the datastore is used for creating a new vm it's looked up on the compute resource, so the fully-qualified inventory path isn't needed.
QA steps
The deployment succeeds and the machine is created on the specified datastore.
Documentation changes
None
Bug reference
https://bugs.launchpad.net/juju/+bug/1874031