Move state multiwatcher package #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, part of this was also to move the Job and Block constants into core/model rather than the params package. These constants were used throughout the code, and had no place in the params package. |
babbageclunk
approved these changes
Nov 3, 2019
| type ApplicationInfo struct { | ||
| // ApplicationResult holds an application info. | ||
| // NOTE: we should look to combine ApplicationResult and ApplicationInfo. | ||
| type ApplicationResult struct { |
There was a problem hiding this comment.
Seems weird to have a type named *Result without any error field.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prelude to making the all watchers combined and their own worker, it made sense to move the actual multiwatcher delta types.
Due to name clashes in the params package, two of the delta types have been renamed to use Update suffix rather than Info.
There is only one actual difference in this change, and it is in serialization param for the address type. The new Address uses "space-id" for the provider ID. The old structure used something else. I'm almost 100% confident that this was never used by the GUI nor anyone else, and I didn't feel that it necessitated having its own type just for something that was unused.