Ensure user store uses lowercased username for document id. #10369
Conversation
state/user.go
Outdated
| @@ -37,12 +37,14 @@ func userIDFromGlobalKey(key string) string { | |||
| } | |||
|
|
|||
| func (st *State) checkUserExists(name string) (bool, error) { | |||
| nameToLower := strings.ToLower(name) | |||
There was a problem hiding this comment.
Personal preference.. but I don't like variables that sound like they're about actions in the future, when they're about the past. imo we're representing a nameLowerCase rather than a nameToLower.
There was a problem hiding this comment.
Yeah agreed, there was already code see addUser which named it this way. So I was going for consistency. I don't mind changing them all.
There was a problem hiding this comment.
It looks like the variables in those private methods were created 4 years ago. We probably won't hurt anyone's feelings by changing them now.
Maybe add to PR?
Not sure. The user name validation allows upper case explicitly in it's regex and the add user logic already supports this (hence why the mongo ids are lowercased) |
hpidcock
force-pushed
the
1833449-register-uppercase-username
branch
from
5005ffd to
9170356
Compare
|
|
Description of change
Not all user store operations correctly formatted the mongo document id.
This fixes the behaviour in all affected user state functions and add tests to ensure this behaviour works.
Previously
juju registerwith a secret token failed because the update password didn't behave correctly when a username contained uppercase.QA steps
Adding a user and registering that user should succeed when the username contains uppercase.
Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1833449