Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes lp#1833629: errors point to 'add-cloud --replace'. #10368

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Fixes lp#1833629: errors point to 'add-cloud --replace'. #10368

merged 1 commit into from
Jun 24, 2019

Conversation

anastasiamac
Copy link
Contributor

Description of change

Whilst 'add-cloud --replace' has been deprecated and the help text clearly states so, the error messages were still referring to it.

This PR updates missed error messages to point to a new way of updating clouds definitions.

QA steps

Running 'add-cloud' on a known, existing cloud should err out with the messaging directing users to 'update-cloud' command instead.

$ juju add-cloud --local fluffystack -f ~/a.yaml
ERROR "fluffystack" already exists; use `update-cloud` to replace this existing cloud

Bug reference

https://bugs.launchpad.net/juju/+bug/1833629

@anastasiamac
Copy link
Contributor Author

lp#1833629: add-cloud command has circular messaging

hpidcock
hpidcock approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anastasiamac
Copy link
Contributor Author

got to love this: Error: retrieving gpg key timed out.

@anastasiamac
Copy link
Contributor Author

!!build!!

@anastasiamac
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit 0bfc932 into juju:2.6 Jun 24, 2019
@manadart manadart mentioned this pull request Jun 24, 2019
Merged
jujubot added a commit that referenced this pull request Jun 24, 2019
@jujubot
Merge pull request #10373 from manadart/2.6-into-develop
d13b59a 
#10373

## Description of change

Merge from 2.6 to bring forward:
- #10372 from manadart/2.6-app-config-branch-error
- #10368 from anastasiamac/ref-non-deprecated-update-cloud-26
- #10348 from hpidcock/1832779-command-fails-no-active-controller
@anastasiamac anastasiamac deleted the ref-non-deprecated-update-cloud-26 branch July 5, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpidcock hpidcock hpidcock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anastasiamac @hpidcock @jujubot