2.6 - Fix Errant Branch Tracking by Cache Config Watcher #10364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king a changed branch. Includes misleading vestigial comment fixes.
|
|
|
Failed to start Mongo. |
jujubot
added a commit
that referenced
this pull request
Jun 22, 2019
#10367 ## Description of change Merge into develop, bringing forward: - #10366 from manadart/2.6-cache-testing-infrastructure - #10364 from manadart/2.6-config-watch-branch-determination - #10362 from anastasiamac/merge-25-26-2106 - #10346 from hmlanigan/branch - #10359 from hmlanigan/createdtomodelcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This patch fixes an edge case in the cache charm config watcher where a unit not tracking any branch would start tracking a branch changed in the cache.
Includes some outdated comment updates.
QA steps
See new unit test; fails before, passes after.
Documentation changes
None.
Bug reference
N/A