Handle the case where the state pool returns NotFound error. #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2019
babbageclunk
approved these changes
Jun 13, 2019
| @@ -3889,7 +3909,7 @@ func (tw *testWatcher) AssertNoChange(c *gc.C) { | |||
| func (tw *testWatcher) AssertChanges(c *gc.C, expected int) { | |||
| var count int | |||
| tw.st.StartSync() | |||
| maxWait := tw.st.clock().After(testing.LongWait) | |||
| maxWait := time.After(testing.LongWait) | |||
| // The entity's model is gone so remove the entity | ||
| // from the store. | ||
| doc.removed(all, modelUUID, id, nil) | ||
| // The state pool will return a not found error if the model is |
There was a problem hiding this comment.
Oof, that's a nasty place to miss a not.
jujubot
added a commit
that referenced
this pull request
Jun 13, 2019
#10322 If the watcher backing the cache worker is shut down cleanly, that worker exists - for any other error, a new watcher is created and the worker proceeds. This branch includes the same patch as #10321 and supersedes #10319. The code is all taken from #10319 and a test to the allwatcher added. Along with a drive by fix for a max wait time. From previous PR: This patch does 2 main things: - If a model is removed, it prevents a running all-watcher from closing. - If the watcher backing the cache worker is shut down cleanly, that worker exists - for any other error, a new watcher is created and the worker proceeds. ## QA steps Reproduce: - With 2.6.3, bootstrap. - Run juju debug log -m controller in a separate terminal. - juju destroy-model default -y and observe the "model not found" errors. Confirm: - Same as above and observe that the cache does not bounce, and the "not found" errors are gone. ## Bug reference https://bugs.launchpad.net/juju/+bug/1832294
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens if a model is dying and being removed from the pool, but isn't yet removed.
Bug reference
Partial fix for https://bugs.launchpad.net/juju/+bug/1832294