Updates unit BSON document to store CharmURL as a string pointer instead

of *charm.URL. There is an overhead for parsing the stored URL, which we are paying whether we access it or not.
juju · Dec 6, 2021 · d5b2ff0 · d5b2ff0
1 parent f346023
commit d5b2ff0
Show file tree

Hide file tree

Showing 24 changed files with 229 additions and 165 deletions.
diff --git a/api/uniter/unit.go b/api/uniter/unit.go
@@ -503,9 +503,6 @@ func (u *Unit) ClosePorts(protocol string, fromPort, toPort int) error {
 var ErrNoCharmURLSet = errors.New("unit has no charm url set")
 
 // CharmURL returns the charm URL this unit is currently using.
-//
-// NOTE: This differs from state.Unit.CharmURL() by returning
-// an error instead of a bool, because it needs to make an API call.
 func (u *Unit) CharmURL() (*charm.URL, error) {
 	var results params.StringBoolResults
 	args := params.Entities{

diff --git a/apiserver/facades/agent/uniter/mocks/lxdprofile.go b/apiserver/facades/agent/uniter/mocks/lxdprofile.go