Skip to content

Fix flaky tests #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anirudh711 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flaky tests #353

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b240a
fix flaky tests
anirudh711 Nov 12, 2023
21b1a99
formatting changes
anirudh711 Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
formatting changes
  • Loading branch information
@anirudh711
anirudh711 committed Nov 12, 2023
commit 21b1a99cbc580f21e39fdadb8488398eb516724e
2 changes: 1 addition & 1 deletion src/test/java/com/jsoniter/extra/TestPreciseFloat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ public void test_indirect_encode() throws JSONException {
obj.field2 = 0.12345678d;
obj.field3 = 0.12345678f;
obj.field4 = 0.12345678f;
JSONAssert.assertEquals("{\"field1\":0.12345678,\"field2\":0.12345678,\"field3\":0.12345678,\"field4\":0.12345678}", JsonStream.serialize(obj),false);
JSONAssert.assertEquals("{\"field1\":0.12345678,\"field2\":0.12345678,\"field3\":0.12345678,\"field4\":0.12345678}", JsonStream.serialize(obj), false);
}
}
2 changes: 1 addition & 1 deletion src/test/java/com/jsoniter/output/TestGenerics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ public void test_wildcard() throws IOException, JSONException {
HashMap<String, Object> map = new HashMap<String, Object>();
map.put("hello", 1);
obj.field2 = map;
JSONAssert.assertEquals("{\"field\":[1],\"field2\":{\"hello\":1}}", JsonStream.serialize(obj),false);
JSONAssert.assertEquals("{\"field\":[1],\"field2\":{\"hello\":1}}", JsonStream.serialize(obj), false);
}
}
4 changes: 2 additions & 2 deletions src/test/java/com/jsoniter/output/TestGson.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public void test_serializeNulls() throws JSONException {

gson = new GsonBuilder().serializeNulls().create();
output = gson.toJson(obj);
JSONAssert.assertEquals("{\"field1\":null,\"field2\":0}", output,false);
JSONAssert.assertEquals("{\"field1\":null,\"field2\":0}", output, false);

GsonCompatibilityMode config = new GsonCompatibilityMode.Builder()
.build();
Expand All @@ -106,7 +106,7 @@ public void test_serializeNulls() throws JSONException {
config = new GsonCompatibilityMode.Builder()
.serializeNulls().build();
output = JsonStream.serialize(config, obj);
JSONAssert.assertEquals("{\"field1\":null,\"field2\":0}", output,false);
JSONAssert.assertEquals("{\"field1\":null,\"field2\":0}", output, false);
}

public void test_setDateFormat_with_style() {
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/com/jsoniter/output/TestNested.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public void test_object_of_array() throws IOException, JSONException {
" \"field2\": \"2\"\n" +
" }\n" +
" ]\n" +
"}".replace('\'', '"'), baos.toString(),false);
"}".replace('\'', '"'), baos.toString(), false);
} finally {
JsonStream.setIndentionStep(0);
}
Expand All @@ -103,7 +103,7 @@ public void test_map_of_objects() throws IOException, JSONException {
" \"field1\": \"1\",\n" +
" \"field2\": \"2\"\n" +
" }\n" +
"}".replace('\'', '"'), baos.toString(),false);
"}".replace('\'', '"'), baos.toString(), false);
} finally {
JsonStream.setIndentionStep(0);
}
Expand Down
12 changes: 6 additions & 6 deletions src/test/java/com/jsoniter/output/TestObject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@ public void test_omit_null() throws JSONException {
assertEquals("{\"field3\":null}", JsonStream.serialize(new TestObject11()));
TestObject11 obj = new TestObject11();
obj.field1 = "hello";
JSONAssert.assertEquals("{\"field1\":\"hello\",\"field3\":null}", JsonStream.serialize(obj),false);
JSONAssert.assertEquals("{\"field1\":\"hello\",\"field3\":null}", JsonStream.serialize(obj), false);
obj = new TestObject11();
obj.field2 = "hello";
JSONAssert.assertEquals("{\"field2\":\"hello\",\"field3\":null}", JsonStream.serialize(obj),false);
JSONAssert.assertEquals("{\"field2\":\"hello\",\"field3\":null}", JsonStream.serialize(obj), false);
obj = new TestObject11();
obj.field3 = 3;
assertEquals("{\"field3\":3}", JsonStream.serialize(obj));
Expand Down Expand Up @@ -294,7 +294,7 @@ public void test_indention() throws JSONException {
" \"field1\": \"1\",\n" +
" \"field2\": \"2\",\n" +
" \"field3\": null\n" +
"}", output,false);
"}", output, false);
Config reflectionCfg = new Config.Builder()
.indentionStep(2)
.encodingMode(EncodingMode.REFLECTION_MODE)
Expand All @@ -304,7 +304,7 @@ public void test_indention() throws JSONException {
" \"field1\": \"1\",\n" +
" \"field2\": \"2\",\n" +
" \"field3\": null\n" +
"}", output,false);
"}", output, false);
}

public static class TestObject15 {
Expand Down Expand Up @@ -357,12 +357,12 @@ public void test_omit_default() throws JSONException {
Config cfg = new Config.Builder()
.omitDefaultValue(true)
.build();
JSONAssert.assertEquals("{\"l\":1,\"d\":1}", JsonStream.serialize(cfg, new TestObject17()),false);
JSONAssert.assertEquals("{\"l\":1,\"d\":1}", JsonStream.serialize(cfg, new TestObject17()), false);
cfg = new Config.Builder()
.omitDefaultValue(true)
.encodingMode(EncodingMode.DYNAMIC_MODE)
.build();
JSONAssert.assertEquals("{\"l\":1,\"d\":1}", JsonStream.serialize(cfg, new TestObject17()),false);
JSONAssert.assertEquals("{\"l\":1,\"d\":1}", JsonStream.serialize(cfg, new TestObject17()), false);
}

public static class TestObject18 {
Expand Down