Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat ajax tests are failing on Chrome 46 #2673

Closed
gibson042 opened this issue Oct 23, 2015 · 4 comments
Closed

Compat ajax tests are failing on Chrome 46 #2673

gibson042 opened this issue Oct 23, 2015 · 4 comments
Assignees
@gibson042
Labels
1.x-only Ajax Works For Me

Comments

@gibson042
Copy link
Member

http://swarm.jquery.org/result/728285

The issue identified in http://bugs.jquery.com/ticket/14683#comment:12 has apparently been resolved as of Chrome 46, so passing invalid URLs to jQuery.ajax now creates a state where no exception is thrown and our callback will never be invoked.
@gibson042 gibson042 self-assigned this Oct 23, 2015
@gibson042 gibson042 added this to the 3.0.0 milestone Oct 23, 2015
gibson042 added a commit to gibson042/jquery that referenced this issue Oct 23, 2015
@gibson042
Ajax: Catch synchronous readystatechange events
0a6e1c4 
Fixes jquerygh-2673
Ref trac-14683
@gibson042
Copy link
Member Author

Closed by 0a6e1c4.

@mgol
Copy link
Member

mgol commented Jan 11, 2016

@gibson042 I see this didn't make it into 1.12.0. Is it no longer needed? If so, a milestone should be cleared & the issue marked as wontfix.

@gibson042
Copy link
Member Author

0a6e1c4 is a cleaner approach and should have made it in, but if we're not failing tests then I guess it's no big deal.

@mgol
Copy link
Member

mgol commented Jan 12, 2016

Yeah, tests are passing. I'm clearing the milestone then.

@mgol mgol removed this from the 3.0.0 milestone Jan 12, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gibson042 gibson042

Labels
1.x-only Ajax Works For Me
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gibson042 @mgol