Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose jQuery.acceptData #2555

Closed
jbedard opened this issue Aug 23, 2015 · 6 comments
Closed

Don't expose jQuery.acceptData #2555

jbedard opened this issue Aug 23, 2015 · 6 comments
Labels
Data
Milestone
3.0.0

Comments

@jbedard
Copy link
Contributor

jbedard commented Aug 23, 2015

Similar to the other "don't expose" cases. Is there any reason for this to be exposed and undocumented?
@markelog
Copy link
Member

Hm, i guess one might argue that this function could be useful to plugin writers, but it seems we just should stop exposing it instead, then documenting it

@markelog markelog added the Data label Aug 23, 2015
@timmywil
Copy link
Member

@arschmitz @scottgonzalez Do you use this in mobile/UI?

@jbedard
Copy link
Contributor Author

jbedard commented Aug 24, 2015

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it. Today it is also copied into Data, so overriding it would be buggy anyway.

@arschmitz
Copy link
Member

@timmywil this is not used by either ui or mobile

@markelog
Copy link
Member

@timmywil this is not used by either ui or mobile

It seems we're good of stop exposing it, @jbedard would you like to send us a pr?

@mgol
Copy link
Member

mgol commented Aug 24, 2015

Another option is to still expose it but use the internal var instead of jQuery.acceptData to save some bytes and not support overriding it.

By "exposing" we mean putting it on the jQuery object so that it's accessible in the compiled version. If you just use AMD modules you can get to a lot of internal stuff already, we just don't guarantee the file hierarchy doesn't change: it might do even in a patch release.

jbedard added a commit to jbedard/jquery that referenced this issue Aug 25, 2015
@jbedard
Data: Don't expose jQuery.acceptData
7308dab 
jQuery.acceptData is an undocumented internal API that shouldn't be exposed.

Fixes jquerygh-2555
@jbedard jbedard mentioned this issue Aug 25, 2015
Closed
@mgol mgol added this to the 3.0.0 milestone Aug 25, 2015
@mgol mgol closed this as completed in 2242719 Sep 7, 2015
mgol pushed a commit that referenced this issue Sep 7, 2015
@jbedard @mgol
Data: Don't expose jQuery.acceptData
bec2ba2 
jQuery.acceptData is an undocumented internal API that shouldn't be exposed.

(cherry-picked from 2242719)

Fixes gh-2555
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Data
Milestone
3.0.0
Development

No branches or pull requests
5 participants
@jbedard @timmywil @arschmitz @markelog @mgol