-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch property needs to be quoted in Android 2.3 #2478
Comments
Or maybe we should just turn on the |
Probably easier to left a comment in the source code? As inline rule or just as a warning? |
I'm concerned that since Android 2.3 chokes on it, there may be other
reserved words that don't work as property names. It would be safer to
switch es3 on (with a support comment that it's just for Android 2.3) and
be sure everything is quoted.
|
Is there? Every reserved word should trigger such error, if that the case, then we should enable es3. |
I didn't check all but at least |
Android 2.3 chokes on unquoted reserved words being used as property names which was making Deferred tests not run. Acknowledge the sad fact that Android 2.3 is not ES5-compliant browser and enable the "es3" option in JSHint config. Fixes jquerygh-2478
PR: #2481. |
Apparently Android 2.3 doesn't like a
catch
property and so it fails deferred tests completely since 84ccf26. We need to quote it as on thecompat
branch.Do we have any way to ensure we don't change it back without turning on the JSHint
es3
option? :/ Or maybe via JSCS? cc @rwaldron @markelog.The text was updated successfully, but these errors were encountered: