Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant 'cd jquery' command in README.md #2359

Closed
elas7 opened this issue May 29, 2015 · 2 comments
Closed

Redundant 'cd jquery' command in README.md #2359

elas7 opened this issue May 29, 2015 · 2 comments

Comments

@elas7
Copy link

elas7 commented May 29, 2015

In line 169 of README.md, the following command is suggested to start 'grunt watch'

cd jquery && grunt watch

The cd jquery part seems to be redundant, considering that the previous command in the instructions is npm install.
Also, the only other part of README.md that uses cd jquery is when explicitly instructing to enter the jquery directory after cloning the jquery repo.
@mr21
Copy link
Contributor

mr21 commented May 29, 2015

+1
or maybe something like this:

$> pwd
jquery
$> grunt watch

markelog added a commit that referenced this issue May 29, 2015
@markelog
Docs: remove redundant instruction from the readme
e6a492d 
(Cherry-picked from 3c92770)
Thanks @elas7

Fixes gh-2359
@markelog
Copy link
Member

Thank you!

markelog added a commit that referenced this issue Nov 10, 2015
@markelog
Docs: remove redundant instruction from the readme
a6ada95 
Thanks @elas7

Fixes gh-2359
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mr21 @markelog @elas7