Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated bind, unbind, delegate, undelegate methods #2288

Closed
markelog opened this issue May 9, 2015 · 7 comments
Closed

Deprecated bind, unbind, delegate, undelegate methods #2288

markelog opened this issue May 9, 2015 · 7 comments
Assignees
@dmethvin
Labels
Docs Event
Milestone
3.0.0

Comments

@markelog
Copy link
Member

markelog commented May 9, 2015

I guess it is time to do this.

  1. Move them to deprecated module
  2. Add warnings into jquery-migrate
  3. Update the docs
@markelog markelog added the Event label May 9, 2015
@markelog markelog added this to the 3.0.0 milestone May 9, 2015
@markelog markelog added the Docs label May 9, 2015
@arthurvr
Copy link
Member

arthurvr commented May 9, 2015

Yes please! 👍

@dmethvin
Copy link
Member

I'm okay with all these todos, although I don't think we'd actually remove them quickly given how much code is still around that uses it. They are very small stubs anyway.

@mgol
Copy link
Member

mgol commented May 10, 2015

@dmethvin Agreed. I don't think it's worth removing them any time soon because of their extremely small size & widespread adoption but discouraging use seems OK.

That said, with current setup only Migrate users & people looking at the docs will see the warnings; maybe we should do it in Core as well?

@dmethvin
Copy link
Member

As long as we don't actually remove them any time soon, the warning in Migrate should be fine.

@markelog
Copy link
Member Author

Yeah, definitely, no hurry.

@dmethvin dmethvin self-assigned this Oct 1, 2015
dmethvin added a commit that referenced this issue Oct 1, 2015
@dmethvin
Event: Move .bind() and .delegate() to deprecated
d58a892 
Fixes #2288
@dmethvin dmethvin mentioned this issue Oct 1, 2015
Closed
@dmethvin dmethvin mentioned this issue Oct 12, 2015
Closed
dmethvin added a commit that referenced this issue Oct 12, 2015
@dmethvin @markelog
Event: Move .bind() and .delegate() to deprecated
7e78c2e 
Cherry-picked from ee0854f
Fixes gh-2288
Closes gh-2624
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@sabberworm
Copy link

The docs still don’t mention the deprecation even though this issue is closed and it specifically says “3. Update the docs”…

See jquery/api.jquery.com#945.

@markelog
Copy link
Member Author

markelog commented Jul 7, 2016

Yeah, you right, although i don't think we should re-open this ticket, let's just discuss this in jquery/api.jquery.com#945? Btw would you like to send us a PR for it? If @teo1978 does not beat you to it?

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmethvin dmethvin

Labels
Docs Event
Milestone
3.0.0
Development

No branches or pull requests
5 participants
@sabberworm @dmethvin @markelog @mgol @arthurvr