Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate jQuery.unique #2228

Closed
gibson042 opened this issue Apr 22, 2015 · 3 comments
Closed

Deprecate jQuery.unique #2228

gibson042 opened this issue Apr 22, 2015 · 3 comments
Assignees
@timmywil
Labels
Core
Milestone
1.12.0/2.2.0

Comments

@gibson042
Copy link
Member

jQuery.unique is an alias to the better-named Sizzle.uniqueSort, and the fact that it sorts has surprised even our own team members.

We should deprecate jQuery.unique in favor of jQuery.uniqueSort (which will need to be introduced).
@gibson042 gibson042 added the Core label Apr 22, 2015
@gibson042 gibson042 added this to the 3.0.0 milestone Apr 22, 2015
@dcherman
Copy link
Contributor

👍

Personally, all of my usage of $.unique has been for the side effect that it sorts the collection. I usually end up doing var sortByDomOrder = $.unique to make that clear to people that aren't familiar with that side effect, so this name change will be nice.

@dmethvin
Copy link
Member

SGTM too 👍

@timmywil
Copy link
Member

Woot! 👍

@timmywil timmywil self-assigned this May 4, 2015
This was referenced May 4, 2015
Closed
Closed
timmywil added a commit that referenced this issue May 4, 2015
@timmywil
Selector: add jQuery.uniqueSort; deprecate jQuery.unique
d9d930f 
Fixes gh-2228
timmywil added a commit that referenced this issue Nov 10, 2015
@timmywil @markelog
Selector: add jQuery.uniqueSort; deprecate jQuery.unique
b03cc96 
Fixes gh-2228
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Core
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
4 participants
@dmethvin @timmywil @dcherman @gibson042