Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose jQuery.swap #2058

Closed
mgol opened this issue Feb 3, 2015 · 5 comments
Closed

Don't expose jQuery.swap #2058

mgol opened this issue Feb 3, 2015 · 5 comments
Assignees
@mgol
Labels
CSS
Milestone
1.12.0/2.2.0

Comments

@mgol
Copy link
Member

mgol commented Feb 3, 2015

Even if we want/need jQuery.swap internally, we still shouldn't expose it, there is no reason to do it now that we have a robust modular architecture. The method is undocumented so technically we could stop exposing it whenever we want; no better moment to do it than the 3.0 release!

I didn't see it in the code but just to make sure: @scottgonzalez & @arschmitz, I assume UI/Mobile doesn't depend on it?
@scottgonzalez
Copy link
Member

We definitely don't use it in UI.

@arschmitz
Copy link
Member

I didn't even know it existed until i saw the related discussion. It's definitely not in mobile either.

@timmywil
Copy link
Member

timmywil commented Feb 3, 2015

Sounds good to me! I think it was originally exposed so users could have control over when to retrieve useful values for hidden elements, but that use case is rare at best.

@mgol
Copy link
Member Author

mgol commented Feb 3, 2015

OK then, assigning to myself!

@mgol mgol self-assigned this Feb 3, 2015
@mgol mgol added this to the 3.0.0 milestone Feb 3, 2015
@mgol mgol added the CSS label Feb 3, 2015
@dmethvin
Copy link
Member

dmethvin commented Feb 3, 2015

If it turns out something needs it but we don't want it internally, we could put it in jQuery Migrate. I doubt it's used externally and we never documented it, plus it's really bad practice from a performance standpoint.

@mgol mgol mentioned this issue Mar 30, 2015
Closed
mgol added a commit to mgol/jquery that referenced this issue Mar 30, 2015
@mgol
CSS: Don't expose jQuery.swap
8b71f33 
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes jquerygh-2058
Closes jquerygh-2182
@mgol mgol closed this as completed in bb4d888 Apr 13, 2015
mgol added a commit that referenced this issue Apr 13, 2015
@mgol @timmywil
CSS: Don't expose jQuery.swap
02a9d9f 
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes gh-2058
Closes gh-2182
mgol referenced this issue Jun 1, 2015
@mgol
Fix #10814. Make support tests lazy and broken out to components.
bbbdd94
This was referenced Jul 31, 2015
Closed
Closed
mgol added a commit that referenced this issue Nov 10, 2015
@mgol @markelog
CSS: Don't expose jQuery.swap
3fdd2dd 
jQuery.swap was an undocumented API used only internally. With the modular
AMD system we currently have it's not necessary to expose this function
publicly under the jQuery object.

Fixes gh-2058
Closes gh-2182
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@wwuck wwuck mentioned this issue Jan 29, 2016
Closed
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@dejvo dejvo mentioned this issue Jun 30, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mgol mgol

Labels
CSS
Milestone
1.12.0/2.2.0
Development

Successfully merging a pull request may close this issue.

CSS: Don't expose jQuery.swap mgol/jquery
5 participants
@scottgonzalez @dmethvin @timmywil @arschmitz @mgol