-
Notifications
You must be signed in to change notification settings - Fork 20.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Issue while creating dash-delimited nodes #1987
Comments
So we would be on same page here: Characters that could be used in tag name of custom elements are described in xml specification. Like But this discussion could be deferred and i let @dmethvin answer that. Apart from that, this looks like real use-case and real bug, there is two problems with this particular case: first with Your commit, mentioned in this ticket, would resolve This is why even Would you like to send us PR for both? |
Preferable with two commits in it, one for core and one for manipulation module, don't forget to read http://contribute.jquery.org/ if you feeling up to it |
Thanks for the instructions, and yes, I'd like to submit a PR for it. Just to be clear and fair, issue was initially reported and patched by @gkalpak on Angular.js repo. It just happened that I bumped into it at the same time and tried to share the load. |
To be even more clear and fair, @elaijuh first reported it on the AngularJS repo. @LeonardoBraga: I am glad you are sharing the load (since I am not familiar with jQuery's contributing conventions 😃). (Seems like a whole lot of people are involved into this one-character addition 😆 How cool is that ?) |
cool to see this, thanks all for helping on this. |
Do we know in which version this is going to be included ? |
3.0 |
This has been backported to |
JQuery fails in some cases to create dash-delimited notes:
Reported first here: angular/angular.js#10617
The text was updated successfully, but these errors were encountered: