Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unit tests work with selector-native.js #1742

Closed
mgol opened this issue Oct 21, 2014 · 3 comments
Closed

Make unit tests work with selector-native.js #1742

mgol opened this issue Oct 21, 2014 · 3 comments
Assignees
@timmywil
Labels
Selector
Milestone
3.0.0

Comments

@mgol
Copy link
Member

mgol commented Oct 21, 2014

Originally reported by dmethvin at: http://bugs.jquery.com/ticket/13537

It would be good to have the native selector engine run a clean subset of unit tests as a sanity check. It wouldn't hurt to wait on this until we get some user feedback though.

Issue reported for jQuery 2.0b1
@mgol mgol self-assigned this Oct 21, 2014
@mgol mgol added this to the Future milestone Oct 21, 2014
@mgol mgol added the 2.x-only label Oct 21, 2014
@mgol
Copy link
Member Author

mgol commented Oct 21, 2014

Comment author: m_gol

I'll look into it.

@timmywil timmywil assigned timmywil and unassigned mgol Jan 30, 2015
@timmywil
Copy link
Member

I can resolve this when I get to a bug with selector-native. #2048

@timmywil timmywil removed their assignment Mar 4, 2015
@mgol
Copy link
Member Author

mgol commented Oct 26, 2015

Since we only have master now, I'm removing the master-only label, it's no longer useful.

@mgol mgol removed the 2.x-only label Oct 26, 2015
timmywil added a commit to timmywil/jquery that referenced this issue Nov 10, 2015
@timmywil
Selector: pass jQuery unit tests with selector-native
cbc08a2 
- Ignore certain tests that obviously are not supported

Fixes jquerygh-1742
Fixes jquerygh-2048
@timmywil timmywil self-assigned this Nov 10, 2015
@timmywil timmywil modified the milestones: 3.0.0, Future Nov 10, 2015
@timmywil timmywil mentioned this issue Nov 10, 2015
Closed
timmywil added a commit to timmywil/jquery that referenced this issue Nov 10, 2015
@timmywil
Selector: pass jQuery unit tests with selector-native
75f24c8 
- Ignore certain tests that obviously are not supported
- Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions

Fixes jquerygh-1742
Fixes jquerygh-2048
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Selector
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@dmethvin @timmywil @mgol