Skip to content

Commit

Permalink
Tests: Keep test iframes around for assertions
Browse files Browse the repository at this point in the history
Ref 44f8239
Ref gh-2644
Ref gh-2390
  • Loading branch information
gibson042 committed Oct 17, 2015
1 parent 0703fd5 commit 0fb84fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/data/testinit.js
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,9 @@ this.testIframeWithCallback = function( title, fileName, func ) {
setTimeout( function() {
this.iframeCallback = undefined;

iframe.remove();
func.apply( this, args );
func = function() {};
iframe.remove();

done();
} );
Expand Down

2 comments on commit 0fb84fa

@timmywil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gibson042 Should this be cherry-picked to compat?

@gibson042
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should cherry-pick all of yesterday's commits, but we can do it in a block to keep the developer summit focused.

Please sign in to comment.