Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on fs2 #9

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Remove dependency on fs2 #9

merged 1 commit into from
Oct 3, 2024

Conversation

jan-pieter
Copy link
Contributor

@jan-pieter jan-pieter commented Oct 2, 2024 •
edited
Loading

This project should not depend on fs2 as it should be implementation-agnostic.

@jan-pieter
Remove dependency on fs2
19cca5a 
This project should not depend on fs2
@jan-pieter jan-pieter marked this pull request as ready for review October 2, 2024 13:56
@jan-pieter jan-pieter requested a review from a team as a code owner October 2, 2024 13:56
@jserranohidalgo jserranohidalgo self-assigned this Oct 3, 2024
jserranohidalgo
jserranohidalgo approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jserranohidalgo jserranohidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks, Jan

@jserranohidalgo jserranohidalgo merged commit e819603 into jqscala:main Oct 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserranohidalgo jserranohidalgo jserranohidalgo approved these changes

Assignees

@jserranohidalgo jserranohidalgo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-pieter @jserranohidalgo