feat: support spaces between quantity and unit in convertMany() and ms()

jonahsnider · Jun 4, 2024 · 8f7eb2d · 8f7eb2d
1 parent c403802
commit 8f7eb2d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/converters/convert-many.test.ts b/src/converters/convert-many.test.ts
@@ -15,6 +15,13 @@ describe('conversions', () => {
 		{ from: '-1m', to: [-1, 'm'] },
 		{ from: '0.1m', to: [0.1, 'm'] },
 		{ from: '-0.1m', to: [-0.1, 'm'] },
+
+		{ from: '1 m', to: [1, 'm'] },
+		{ from: '-.1 m', to: [-0.1, 'm'] },
+		{ from: '-1 m', to: [-1, 'm'] },
+		{ from: '1m 1 m', to: [2, 'm'] },
+		// Doesn't parse double spaces
+		{ from: '1m 1  m', to: [1, 'm'] },
 	])('$from -> $to', ({ from, to }) => {
 		// biome-ignore lint/suspicious/noExplicitAny:
 		expect(convertMany(from).to(to[1] as any)).toBe(to[0]);

diff --git a/src/converters/convert-many.ts b/src/converters/convert-many.ts
@@ -4,7 +4,7 @@ import { convert } from './convert';
 
 import type { BestUnits, Unit } from '../types/units';
 
-const splitExpression = /(-?(?:\d+)?\.?\d+)(\S+)/g;
+const splitExpression = /(-?(?:\d+)?\.?\d+)\s?(\S+)/g;
 
 type ConverterThis = {
 	_search: RegExpExecArray;